chore: readd changes lost in merge PR #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
Zer0dot,
jaypaik and
Blu-J
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
howydev
force-pushed
the
howy/review-fixes
branch
2 times, most recently
from
09248aa to
abd430f
Compare
howydev
force-pushed
the
howy/review-fixes
branch
from
abd430f to
49d8e1d
Compare
howydev
changed the title
adamegyed
approved these changes
Jan 3, 2025
howydev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on refactoring the naming of exported constants in the
allowlist-module,native-token-limit-module, and other modules to follow a consistent naming convention. It also improves documentation and updates error messages for clarity.Detailed summary
allowlistModuletoAllowlistModuleinallowlist-module/module.ts.nativeTokenLimitModuletoNativeTokenLimitModuleinnative-token-limit-module/module.ts.client.tsandinstallValidation.ts.createSMAV2AccountandserializeValidationConfig.nativeSMASignerfunction to use a default entity ID.