Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): fix execution gas eff check for v0.6 with paymasters #977

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

dancoombs
Copy link
Collaborator

Fixes #976

andysim3d
andysim3d previously approved these changes Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.13%. Comparing base (92ddf82) to head (e400718).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pool/src/mempool/uo_pool.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/uo_pool.rs 92.05% <66.66%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit-tests 59.13% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.60% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.95% <66.66%> (-0.01%) ⬇️
provider 19.49% <ø> (ø)
rpc 26.43% <ø> (ø)
sim 77.04% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.27% <ø> (-0.48%) ⬇️
utils 30.06% <ø> (ø)

@andysim3d andysim3d force-pushed the danc/fix-v0.6-eff-check branch from aac0845 to e400718 Compare January 23, 2025 19:00
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andysim3d andysim3d merged commit f9ce5ad into main Jan 23, 2025
10 checks passed
@andysim3d andysim3d deleted the danc/fix-v0.6-eff-check branch January 23, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pool] Issue with gas efficiency check for v0.6 using a paymaster
3 participants