Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display namespace when SUBJECT is a ServiceAccount #113

Conversation

fjammes
Copy link
Contributor

@fjammes fjammes commented Jul 4, 2024

This PR solves the issue: #112

@fjammes
Copy link
Contributor Author

fjammes commented Jul 17, 2024

Hello, could you please provide some feedback about this proposal?

@gadinaor-r7
Copy link
Contributor

Coming right up

cmd/policyrules_cmd.go Outdated Show resolved Hide resolved
@fjammes fjammes requested a review from gadinaor-r7 October 22, 2024 08:06
Copy link
Contributor

@gadinaor-r7 gadinaor-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM // Thanks

@fjammes
Copy link
Contributor Author

fjammes commented Oct 24, 2024

Hi @gadinaor-r7 , thanks so much for the review. However I do not have permissions to merge the PR, could you please help?

Thanks in advance

@gadinaor-r7 gadinaor-r7 merged commit 83008e2 into alcideio:master Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display namespace for ServiceAccount while running rbac-tool policy-rules -e default
2 participants