-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert kover to python3 #60
base: kover2
Are you sure you want to change the base?
Conversation
Thanks @goepp! I was able to install Kover completely in a docker image with Ubuntu 20.04 and Python 3.8. I then tried to run this tutorial: http://aldro61.github.io/kover/doc_tut_scm.html, which failed. I think the code is using methods that are no longer supported in Python 3. I propose that we work with this tutorial and fix any issues that come up along the way. |
…esting environment
…nge dataset info class since strings are now stored as bytes in h5py
@goepp I did a bit of progress. The |
I am sorry, I don't manage to reproduce your results. I am new to docker, so I may be missing something simple. Running
returns the error
It seems like the installation of kover using
which returns |
No worries! Also, you don't necessarily need to use docker. I'm using it to avoid any issues due to the fact that I'm on macOS (for now). Here are the commands I use: Build the image Run bash to start an interactive terminal in the container: Then I run the tutorial commands. Whenever a command fails, I open up the python file with You could completely skip docker if the installation works on your local machine. |
Thanks!
For reference: I am now at the point where EDIT:
So the indexing of h5py dataset does not work. I must admit I feel lost here. @aldro61 any clue? |
Thanks a lot @goepp! The inconsistent indentation issues are due to an old IDE that I was using at the time. It gave me a lot of headaches! If you want a quick and easy way to fix this, you can install Black and simply run |
Thanks! Using black would ruin the git blaming, shall I carry on, or tell git to ignore the revisions (as explained here)? As explained in the link, this does not work for the GitHub UI. |
Good point. I don't really use |
Done. Running
|
Still stuck at the latter point (#60 (comment)) though. |
Thanks @goepp! I will take some time today to investigate. |
Working notes:
building wheel for kover
returns an error.