Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token decimals from BSC #146

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Fix token decimals from BSC #146

merged 3 commits into from
Nov 4, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Nov 4, 2024

The decimals for USDT and USDC on BSC are 18, which is different from ETH.

@Lbqds Lbqds requested a review from h0ngcha0 November 4, 2024 09:33
@polarker
Copy link
Member

polarker commented Nov 4, 2024

Maybe let's add a test for mainnet metadata?

@Lbqds
Copy link
Member Author

Lbqds commented Nov 4, 2024

Maybe let's add a test for mainnet metadata?

Sounds great, will add!

Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lbqds Lbqds merged commit f426262 into master Nov 4, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants