Fix walletconnect issues #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lbqds
commented
Dec 25, 2024
| @@ -23,7 +23,7 @@ | |||
| "@solana/web3.js": "^1.35.1", | |||
| "@terra-money/wallet-provider": "^3.8.0", | |||
| "@alephium/walletconnect-qrcode-modal": "0.1.0", | |||
| "@alephium/walletconnect-ethereum-provider": "0.1.1", | |||
| "@walletconnect/ethereum-provider": "2.17.2", | |||
There was a problem hiding this comment.
In the latest WalletConnect, we will separate the WalletConnect storage for Alephium and Ethereum. So we no longer need to maintain a custom Ethereum provider.
Lbqds
commented
Dec 25, 2024
| @@ -219,8 +221,9 @@ export const EthereumProviderProvider = ({ | |||
| EthereumProvider.init({ | |||
| projectId: WALLET_CONNECT_PROJECT_ID, | |||
| showQrModal: false, | |||
| chains: [getEvmChainId(wormholeChainId) as number], | |||
| rpcMap: EVM_RPC_MAP | |||
| chains: [getEvmChainId(CHAIN_ID_ETH) as number, getEvmChainId(CHAIN_ID_BSC) as number], | |||
There was a problem hiding this comment.
In the latest WalletConnect, switching chains does not require user approval but instead requires specifying all chain ids when initializing.
polarker
reviewed
Dec 25, 2024
| import { CLUSTER, ALEPHIUM_BRIDGE_GROUP_INDEX } from "./utils/consts"; | ||
|
|
||
| const connectors = { | ||
| walletConnect: createWalletConnectConnector({customStoragePrefix: 'alephium'}), | ||
| desktopWallet: createDesktopWalletConnector({customStoragePrefix: 'alephium'}) |
There was a problem hiding this comment.
Maybe we should enable this by default in our walletconnect provider? There could be Other projects need to use multiple connectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.