Flexible column counts #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oneElectron. Thanks so much for the PR! |
|
Once a test is added I will merge. I am happy you like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #134
First off, I like and use the project a lot.
For me its a tool to see data better.
Therefore it seems a bit odd that tv doesn't just steamroll over malformed data.
It's tool for me to visualize data, it should try as much as possible to display whatever useful information it has, even if i made a mistake.
TODO
What I did
The csv crate has a flexible mode. If the user did not request for either pedantic mode or jump-invalid-rows, then the code defaults to using flexible mode.
Pedantic mode parses as it did before I put my hands on it.
jump-invalid-rows skips over any row that returned an error when parsing with flexible = false.