This repository has been archived by the owner on May 14, 2020. It is now read-only.
Hover stylings #54
Open
Hover stylings #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 10, 2016 11:17
|
If this is ok, can you merge it? |
alexkuz
suggested changes
Nov 20, 2016
| {...styling('nestedNode', ...stylingArgs)} | ||
| onMouseOver={this.handleMouseOver} | ||
| onMouseOut={this.handleMouseOut} | ||
| > |
There was a problem hiding this comment.
Maybe mouseEnter/mouseLeave are more appropriate here?
| @@ -167,4 +173,11 @@ export default class JSONNestedNode extends React.Component { | |||
| } | |||
|
|
|||
| handleClick = () => this.setState({ expanded: !this.state.expanded }); | |||
|
|
|||
| handleMouseOver = (e) => { | |||
| e.stopPropagation(); | |||
There was a problem hiding this comment.
Why do we need to stop propagation?
|
@mclin sorry it took me so long to review that :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hover state param to 'value', 'nestedNode' and 'rootNode' stylings.
Rebased #51