Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for setting explicit level #43

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"name": "JS Minified",
"path": "dist/*.js",
"gzip": false,
"limit": "1610B"
"limit": "1782B"
},
{
"name": "JS Compressed",
"path": "dist/*.js",
"limit": "748B"
"limit": "786B"
}
]
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ Creates a new section (a heading and its level).
| `component` | `node` | Yes | The heading component. Can be anything but best used in combination with `<H>`. |
| `children` | `node` | No | The content of the new level. |

<!-- TODO update docs with low level api / advanced use case (dialogs & portals) -->

#### Example

```jsx
Expand Down
22 changes: 22 additions & 0 deletions src/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,26 @@ describe("Section component", () => {

expect(pEl.tagName).toBe("P");
});

it("should render a heading at the specified level", () => {
const { getByText } = render(
<Section component={<H>My H1</H>}>
<Section component={<H>My H2</H>}>
<Section component={<H>My H3</H>}>
<Section component={<H>My H2-2</H>} level={2}>
<Section component={<H>My H3-2</H>}></Section>
</Section>
</Section>
</Section>
</Section>
);

const heading2El = getByText("My H2-2");

expect(heading2El.tagName).toBe("H2");

const heading3El = getByText("My H3-2");

expect(heading3El.tagName).toBe("H3");
});
});
57 changes: 43 additions & 14 deletions src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ type HProps = React.DetailedHTMLProps<
render?: (context: LevelContextValue) => React.ReactElement;
};

function InternalH(
/**
* Renders a dynamic HTML heading (h1, h2, etc.) or custom component according to the current level.
*/
export const H = React.forwardRef(function H(
{ render, ...props }: HProps,
forwardedRef: React.ForwardedRef<HTMLHeadingElement>
): JSX.Element {
Expand All @@ -36,37 +39,63 @@ function InternalH(
}

return <context.Component ref={forwardedRef} {...props} />;
}
});

type LevelProps = {
level?: Level;
children?: React.ReactNode;
};

/**
* Renders a dynamic HTML heading (h1, h2, etc.) or custom component according to the current level.
* Renders `children` 1 level down, or at the desired level.
* @param children The children in the next level, or the desired level
* @param level The desired level
*/
export const H = React.forwardRef(InternalH);
function Level({ level: desiredLevel, children }: LevelProps): JSX.Element {
const { level: currentLevel } = useLevel();

const level = desiredLevel ?? (Math.min(currentLevel + 1, 6) as Level);

const value = {
level,
Component: `h${level}` as Heading,
};

return (
<LevelContext.Provider value={value}>{children}</LevelContext.Provider>
);
}

type SectionProps = {
component: React.ReactNode;
children?: React.ReactNode;
level?: Level;
};

/**
* Renders `component` in the current level and `children` in the next level.
* @param component A component containing a heading
* @param children The children in the next level
* @param level A specific level to render instead of the current one
*/
export function Section({ component, children }: SectionProps): JSX.Element {
const { level } = useLevel();

const nextLevel = Math.min(level + 1, 6) as Level;

const value = {
level: nextLevel,
Component: `h${nextLevel}` as Heading,
};
export function Section({
component,
children,
level,
}: SectionProps): JSX.Element {
if (level) {
return (
<Level level={level}>
{component}
<Level>{children}</Level>
</Level>
);
}

return (
<>
{component}
<LevelContext.Provider value={value}>{children}</LevelContext.Provider>
<Level>{children}</Level>
</>
);
}
Loading