-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type checking to the codebase #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
300 errors in 25 files ~> 283 errors in 24 files
283 errors in 24 files ~> 282 errors in 23 files
282 errors in 23 files ~> 291 errors in 23 files
291 errors in 23 files ~> 225 errors in 22 files
225 errors in 22 files ~> 194 errors in 21 files
194 errors in 21 files ~> 178 errors in 19 files
178 errors in 19 files ~> 160 errors in 18 files
160 errors in 18 files ~> 149 errors in 17 files
149 errors in 17 files ~> 97 errors in 16 files
97 errors in 16 files ~> 82 errors in 15 files
82 errors in 15 files ~> 66 errors in 14 files
66 errors in 14 files ~> 65 errors in 13 files
65 errors in 13 files ~> 57 errors in 12 files
57 errors in 12 files ~> 46 errors in 10 files
46 errors in 10 files ~> 38 errors in 9 files
38 errors in 9 files ~> 22 errors in 8 files
22 errors in 8 files ~> 18 errors in 7 files
18 errors in 7 files ~> 11 errors in 5 files
11 errors in 5 files ~> 10 errors in 4 files
10 errors in 4 files ~> 8 errors in 3 files
8 errors in 3 files ~> 4 errors in 2 files
alexwlchan
force-pushed
the
type-checking
branch
from
June 19, 2024 06:17
c8226d9
to
814f405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #154
I've got all the types working locally (I think!). I haven't actually been able to run it locally because I don't have any docstore instances on my MacBook, but this gives me a safety net that I can build on if I come back to this project and want to work on this again.