devonfw#517: Fix get version throws exception when run on not-install…

…ed tool with installed flag (devonfw#518)
alfeilex · Aug 6, 2024 · 86e258c · 86e258c
1 parent 1ef551c
commit 86e258c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/cli/src/main/java/com/devonfw/tools/ide/commandlet/VersionGetCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/commandlet/VersionGetCommandlet.java
@@ -60,8 +60,9 @@ public void run() {
  if (installedVersion == null) {
  this.context.info("No installation of tool {} was found.", commandlet.getName());
  toolInstallInfo(commandlet.getName(), configuredVersion);
+ } else {
+ this.context.info(installedVersion.toString());
  }
- this.context.info(installedVersion.toString());
 
  } else if (!this.installed.isTrue() && this.configured.isTrue()) {// get configured version
 

diff --git a/cli/src/test/java/com/devonfw/tools/ide/commandlet/VersionGetCommandletTest.java b/cli/src/test/java/com/devonfw/tools/ide/commandlet/VersionGetCommandletTest.java
@@ -14,7 +14,7 @@ public class VersionGetCommandletTest extends AbstractIdeContextTest {
  * Test of {@link VersionGetCommandlet} run, when Installed Version is null.
  */
  @Test
- public void testVersionGetCommandletRunThrowsCliException() {
+ public void testVersionGetCommandletNotInstalledRun() {
 
  // arrange
  IdeTestContext context = newContext(PROJECT_BASIC, null, false);
@@ -27,6 +27,23 @@ public void testVersionGetCommandletRunThrowsCliException() {
  "To install that version call the following command:", "ide install java");
  }
 
+ @Test
+ public void testVersionGetCommandletNotInstalledRunInstalledFlag() {
+
+ // arrange
+ IdeTestContext context = newContext(PROJECT_BASIC, null, false);
+ VersionGetCommandlet versionGet = context.getCommandletManager().getCommandlet(VersionGetCommandlet.class);
+ versionGet.tool.setValueAsString("java", context);
+ versionGet.installed.setValue(true);
+ // act
+ versionGet.run();
+ // assert
+ assertThat(context).logAtInfo().hasMessage("No installation of tool java was found.");
+ assertThat(context).logAtInfo().hasMessage("The configured version for tool java is 17*");
+ assertThat(context).logAtInfo().hasMessage("To install that version call the following command:");
+ assertThat(context).logAtInfo().hasMessage("ide install java");
+ }
+
  /**
  * Test of {@link VersionGetCommandlet} run.
  */