Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect standard Scout Algolia config #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samlev
Copy link

@samlev samlev commented Sep 22, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Need Doc update no

Describe your change

This change ensures that standard Laravel Scout configuration for Algolia is respected when using Scout Extended.

What problem is this fixing?

Base Laravel Scout allows you to control certain features of the search client through configuration, but Scout extended ignores those configuratiton options.

This change makes scout extended respect the connect_timeout, read_timeout, write_timeout, and batch_size configuration options.

I will note that base scout also doesn't currently pay attention to batch_size, but that's the one setting that we wanted to change in the first place. I have opened a PR to scout to address this issue there, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant