Fix the va_args order of http header (#286)

alibaba · Dec 4, 2023 · f97ac8f · f97ac8f
1 parent 19099b4
commit f97ac8f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/fs/httpfs/httpfs.cpp b/fs/httpfs/httpfs.cpp
@@ -251,7 +251,9 @@ class HttpFile : public fs::VirtualReadOnlyFile {
  }
 
  void add_header(va_list args) {
- common_header[va_arg(args, const char*)] = va_arg(args, const char*);
+ auto k = va_arg(args, const char*);
+ auto v = va_arg(args, const char*);
+ common_header[k] = v;
  }
 
  void add_url_param(va_list args) { url_param = va_arg(args, const char*); }

diff --git a/fs/httpfs/httpfs_v2.cpp b/fs/httpfs/httpfs_v2.cpp
@@ -230,7 +230,9 @@ class HttpFile_v2 : public fs::VirtualReadOnlyFile {
 
  //TODO: 这里是否需要考虑m_common_header被打爆的问题？
  void add_header(va_list args) {
- m_common_header.insert(va_arg(args, const char*), va_arg(args, const char*));
+ auto k = va_arg(args, const char*);
+ auto v = va_arg(args, const char*);
+ m_common_header.insert(k, v);
  }
 
  void add_url_param(va_list args) { m_url_param = va_arg(args, const char*); }