Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & improves #178

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Fix & improves #178

merged 6 commits into from
Aug 17, 2023

Conversation

Coldwings
Copy link
Collaborator

Bug fix:

  • photon gdb tool script fits current register on stack layout
  • fix unit test designed not fit for mutex lock that may perform thread_yield spin
  • http client dialer leaks tcp_socket_client

Feature:

  • new AsyncAwaiter for Executor and WorkPool implementation


template <>
struct Awaiter<StdContext> {
int err;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处是用future promise代替了原来的cond variable嘛? future promise性能怎么样,最终会被实现成啥同步原语?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC的标准库(libstdc++)中,future的wait动作使用condition_variable的wait_for实现。

@beef9999 beef9999 merged commit 72c37b6 into alibaba:main Aug 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants