add a new function recv_at_least() to socket stream #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge to release/0.7 ? |
beef9999
reviewed
Oct 28, 2023
net/socket.h
Outdated
| @@ -216,6 +216,23 @@ namespace net { | |||
| // may block once at most, when there's no data yet in the socket; | |||
| virtual ssize_t recv(void *buf, size_t count, int flags = 0) = 0; | |||
| virtual ssize_t recv(const struct iovec *iov, int iovcnt, int flags = 0) = 0; | |||
| virtual ssize_t recv_mutable(struct iovec *iov, int iovcnt, int flags = 0) { | |||
| return recv(iov, iovcnt, flags); | |||
| } | |||
There was a problem hiding this comment.
Any chance we need to modify the iovec pointer?
There was a problem hiding this comment.
Because const iovec* is a convention, just like readv/preadv/writev/pwritev ...
Obeying the convention can avoid unnecessary errors.
There was a problem hiding this comment.
Using another function name is also for obeying the convention, despite C++ has function overloading.
There was a problem hiding this comment.
Oh, I made a mistake. In fact recv/send usually makes a single I/O action that doesn't need to modify the iovec[]. Only recv_at_least needs so.
|
LGTM |
beef9999
approved these changes
Oct 30, 2023
beef9999
pushed a commit
that referenced
this pull request
Nov 2, 2023
add new functions recv_at_least() and recv_at_least_mutable() to socket stream
wsgeek
pushed a commit
to wsgeek/PhotonLibOS
that referenced
this pull request
Nov 12, 2023
add new functions recv_at_least() and recv_at_least_mutable() to socket stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to recv at least a number of bytes from socket stream, so as to reduce the # of syscalls