Fix http message #250
Merged
Fix http message #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
commented
Nov 16, 2023
common/estring.cpp
Outdated
| ret = ret * 16 + (c - 'A' + 10); | ||
| } else if (c >= 'a' && c <= 'f') { | ||
| ret = ret * 16 + (c - 'a' + 10); | ||
| unsigned char cc = c - '0'; |
There was a problem hiding this comment.
reducing branches in machine code
lihuiba
commented
Nov 16, 2023
common/estring.cpp
Outdated
| @@ -55,27 +55,34 @@ size_t estring_view::find_last_not_of(const charset& set) const | |||
|
|
|||
| bool estring_view::to_uint64_check(uint64_t* v) const | |||
| { | |||
| v ? (*v = 0) : 0; | |||
| uint64_t val = 0; | |||
There was a problem hiding this comment.
simplify the syntax
lihuiba
force-pushed
the
fix_http_message
branch
from
e73bcac
to
0f625da
Compare
lihuiba
force-pushed
the
fix_http_message
branch
from
0f625da
to
fb53a2f
Compare
lihuiba
commented
Nov 16, 2023
| @@ -331,7 +331,7 @@ int Request::redirect(Verb v, estring_view location, bool enable_proxy) { | |||
| } | |||
| StoredURL u(location); | |||
| auto new_request_line_size = verbstr[v].size() + sizeof(" HTTP/1.1\r\n") + | |||
| enable_proxy ? full_url_size(u) : u.target().size(); | |||
| (enable_proxy ? full_url_size(u) : u.target().size()); | |||
lihuiba
commented
Nov 17, 2023
| auto x = *(xlator *)(&v); | ||
| *(uint32_t *)out = ((tbl[x.a] << 24) + (tbl[x.b] << 16) + | ||
| (tbl[x.c] << 8) + (tbl[x.d] << 0)); | ||
| auto x = (xlator*) &v; |
There was a problem hiding this comment.
to eliminate a warning
beef9999
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix operator priority bug in http/status.cpp;
enhance estring;