[feat] http client with cert #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
beef9999
reviewed
Dec 14, 2023
net/http/client.cpp
Outdated
|
|
||
| ClientImpl(ICookieJar *cookie_jar, TLSContext *tls_ctx) : | ||
| m_cookie_jar(cookie_jar), | ||
| m_dialer(new PooledDialer(tls_ctx)) { |
There was a problem hiding this comment.
m_dialer(tls_ctx)?
So there will be no need to change m_dialer to a pointer.
WaberZhuang
force-pushed
the
release/0.6
branch
from
9c07a1d
to
86bee16
Compare
lihuiba
reviewed
Dec 15, 2023
net/http/client.h
Outdated
| @@ -25,6 +25,7 @@ limitations under the License. | |||
| #include <photon/common/stream.h> | |||
| #include <photon/common/timeout.h> | |||
| #include <photon/net/socket.h> | |||
| #include <photon/net/security-context/tls-stream.h> | |||
There was a problem hiding this comment.
no need to include the header file. just make a forward declaration.
liulanzheng
reviewed
Dec 15, 2023
| @@ -47,6 +47,13 @@ class PooledDialer { | |||
| resolver(new_default_resolver(kDNSCacheLife)) { | |||
| } | |||
|
|
|||
| PooledDialer(TLSContext *_tls_ctx) : | |||
There was a problem hiding this comment.
No need to add a new constructor; simply add a default parameter to the existing constructor. The constructor is involved in the initialization of multiple members, and it is not advisable to maintain multiple versions.
| @@ -110,6 +117,11 @@ class ClientImpl : public Client { | |||
| ClientImpl(ICookieJar *cookie_jar) : | |||
| m_cookie_jar(cookie_jar) {} | |||
|
|
|||
| ClientImpl(ICookieJar *cookie_jar, TLSContext *tls_ctx) : | |||
There was a problem hiding this comment.
It is also possible to reuse the above constructor.
WaberZhuang
force-pushed
the
release/0.6
branch
from
86bee16
to
ab9622c
Compare
liulanzheng
reviewed
Dec 15, 2023
| m_cookie_jar(cookie_jar) {} | ||
| ClientImpl(ICookieJar *cookie_jar, TLSContext *tls_ctx) : | ||
| m_cookie_jar(cookie_jar), | ||
| m_dialer(tls_ctx) { |
There was a problem hiding this comment.
It might be necessary to consider ownership of tls_ctx?
Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com>
WaberZhuang
force-pushed
the
release/0.6
branch
from
ab9622c
to
e85f575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support HTTP client to use specified certificates. It's necessary when two-way authentication is enabled (the server will verify the client's identity) on the HTTP server.