Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-define an undefined endpoint #322

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Re-define an undefined endpoint #322

merged 1 commit into from
Jan 8, 2024

Conversation

beef9999
Copy link
Collaborator

@beef9999 beef9999 commented Jan 5, 2024 •
edited
Loading

When errors happened, we often get an empty Endpoint with an empty IPAddr, but we'll usually not reset zero value to its port.

An empty IP is enough to indicate it's undefined, and makes it more convenient to use.

Another option is to change the condition from AND to OR.

@lihuiba lihuiba merged commit 49a2710 into alibaba:release/0.7 Jan 8, 2024
7 checks passed
beef9999 added a commit that referenced this pull request Jan 9, 2024
@beef9999
Re-define an undefined endpoint (#322)
669af8d
@beef9999 beef9999 deleted the beef9999/minor-14 branch January 9, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihuiba lihuiba lihuiba approved these changes

@Coldwings Coldwings Awaiting requested review from Coldwings

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beef9999 @lihuiba