use Timeout #332
Merged
use Timeout #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These "fix" commits should ideally be squashed into one. |
beef9999
reviewed
Jan 19, 2024
common/timeout.h
Outdated
| operator uint64_t() const { return timeout(); } | ||
| operator bool () const { return m_expire > now; } | ||
| uint64_t timeout_us() const { return timeout(); } | ||
| uint64_t timeout_ms() const { return divide(timeout(), 1000); } |
There was a problem hiding this comment.
void f(Timeout timeout) {
if (timeout) do_xx();
if (timeout.expired()) do_xx();
}
感觉后者的API更清楚一点
will be squashed merged |
EricHuangqx
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread, io engines, socket
move sat_add(), sat_sub() into common/utility.h, reimplemented with compiler intrinsic, instead of inline assembly.
update the interface of class Timeout slightly