http client destroy_operation #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beef9999
commented
May 10, 2024
| if(CCACHE_FOUND) | ||
| set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache) | ||
| endif(CCACHE_FOUND) | ||
|
|
There was a problem hiding this comment.
ccache is not safe enough, especially when switching from debug to release.
Besides, CMake has already supported incremental compile.
beef9999
commented
May 10, 2024
net/http/client.h
Outdated
| @@ -92,16 +101,10 @@ class Client : public Object { | |||
| enable_proxy(c->has_proxy()), | |||
| _client(c) {} | |||
| Operation(uint16_t buf_size) : req(_buf, buf_size) {} | |||
| ~Operation() = default; | |||
| friend void Client::destroy_operation(Operation* op); | |||
There was a problem hiding this comment.
Allow client->destroy_operation(op), while forbid calling delete op
beef9999
force-pushed
the
beef9999/br-14
branch
2 times, most recently
from
1a6007d
to
2f7faf8
Compare
lihuiba
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.