Interruptible throttle; DNS Resolver support filter #495
Conversation
| starving_slice_num++; | ||
| continue; | ||
| } | ||
| break_starving: | ||
| ret = sem.wait(amount, m_time_window_per_slice); | ||
| ret = sem.wait_interruptible(amount, m_time_window_per_slice); |
There was a problem hiding this comment.
可打断的限流在一些场合很有用，比如做了优先级限流之后，一些低优先级的任务在后台排队（睡眠），如果这时候又来了新的相同的高优先级任务，需要打断睡眠，相当于提高优先级。
| @@ -1682,7 +1682,7 @@ R"( | |||
| splock.lock(); | |||
| CURRENT->semaphore_count = count; | |||
| int ret = 0; | |||
| while (!try_substract(count)) { | |||
| while (!try_subtract(count)) { | |||
There was a problem hiding this comment.
substract is old English, which also appears in French and Spanish. In modern English it is subtract.
| @@ -157,7 +157,7 @@ class Resolver : public Object { | |||
| // When failed, return an Undefined IPAddr | |||
| // Normally dns servers return multiple ips in random order, choosing the first one should suffice. | |||
| virtual IPAddr resolve(std::string_view host) = 0; | |||
| virtual void resolve(std::string_view host, Delegate<void, IPAddr> func) = 0; | |||
There was a problem hiding this comment.
Why old API have to be removed?
There was a problem hiding this comment.
等于是用上面那个resolve的结果自己再执行一遍func？
There was a problem hiding this comment.
func(resolve(host)) is good enough (and used to be just implemented like this).
net/utils.h
Outdated
| @@ -157,7 +157,7 @@ class Resolver : public Object { | |||
| // When failed, return an Undefined IPAddr | |||
| // Normally dns servers return multiple ips in random order, choosing the first one should suffice. | |||
| virtual IPAddr resolve(std::string_view host) = 0; | |||
| virtual void resolve(std::string_view host, Delegate<void, IPAddr> func) = 0; | |||
| virtual IPAddr resolve(std::string_view host, Delegate<bool, IPAddr> filter) = 0; | |||
There was a problem hiding this comment.
原本的接口含义被改变了，可能给应用带来breaking change，这没有必要。你可以考虑新增一个接口resolve_filter()。
| @@ -264,24 +264,17 @@ class DefaultResolver : public Resolver { | |||
| IPAddrNode(IPAddr addr) : addr(addr) {} | |||
| }; | |||
| using IPAddrList = intrusive_list<IPAddrNode>; | |||
| public: | |||
| DefaultResolver(uint64_t cache_ttl, uint64_t resolve_timeout) | |||
| : dnscache_(cache_ttl), resolve_timeout_(resolve_timeout) {} | |||
There was a problem hiding this comment.
没动，只是把protected的函数移到了上面，就显得有变化
beef9999
force-pushed
the
beef9999/br-17
branch
3 times, most recently
from
18c7a92
to
e2f362d
Compare
| #define LOG_AUDIT(...) (__LOG__((), default_audit_logger, ALOG_AUDIT, __VA_ARGS__)) | ||
| #else | ||
| #define LOG_AUDIT(...) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
跟 alog-audit.h 统一
PhotonLibOS/common/alog-audit.h
Line 29 in 0db8545
| @@ -157,7 +157,7 @@ class Resolver : public Object { | |||
| // When failed, return an Undefined IPAddr | |||
| // Normally dns servers return multiple ips in random order, choosing the first one should suffice. | |||
| virtual IPAddr resolve(std::string_view host) = 0; | |||
| virtual void resolve(std::string_view host, Delegate<void, IPAddr> func) = 0; | |||
There was a problem hiding this comment.
func(resolve(host)) is good enough (and used to be just implemented like this).
No description provided.