FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t empty/full Signed-off-by: Coldwings <coldwings@me.com>
Signed-off-by: Coldwings <coldwings@me.com>
lihuiba
approved these changes
Jun 8, 2024
lihuiba
added a commit
that referenced
this pull request
Jun 14, 2024
* FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full (#504) * FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full Signed-off-by: Coldwings <coldwings@me.com> * Old CI image not able to access repo, change to preset image Signed-off-by: Coldwings <coldwings@me.com>
lihuiba
added a commit
that referenced
this pull request
Jun 15, 2024
* new CI workflow for linux.x86 (#494) new CI workflow for linux.x86 * CI use images that pre-installed all deps (#505) * Manual pr 0.6 0.7 (#509) * FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full (#504) * FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full Signed-off-by: Coldwings <coldwings@me.com> * Old CI image not able to access repo, change to preset image Signed-off-by: Coldwings <coldwings@me.com> --------- Signed-off-by: Coldwings <coldwings@me.com> Co-authored-by: Coldwings <coldwings@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX:
now mpmcqueue able to be sure not return failure pop from non-empty queue or push into non-full queue.