thread_yield() possible to return error_number obtained from thread_i… #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coldwings
reviewed
Sep 18, 2024
thread/thread.cpp
Outdated
| if (unlikely(th->state != states::SLEEPING)) return; | ||
| if (unlikely(th->state != states::SLEEPING)) { | ||
| out: // may have thread_yield()-ed | ||
| if (th->state != states::READY || th->error_number == 0) |
There was a problem hiding this comment.
Should it be
th->state == states::READY && th->error_number == 0?
Means thread is in READY queue and error number not set
lihuiba
force-pushed
the
yield_with_error_number-0.8
branch
from
68ba89f
to
d074713
Compare
lihuiba
added a commit
that referenced
this pull request
Sep 18, 2024
* Fix pooled stack allocator in-pool size calculation (#542) Signed-off-by: Coldwings <coldwings@me.com> * fix fstack-dpdk build in release/0.8 (#547) * add fstack CI (#549) * thread_yield() possible to return error_number obtained from thread_interrupt() (#560) --------- Signed-off-by: Coldwings <coldwings@me.com> Co-authored-by: Coldwings <coldwings@me.com> Co-authored-by: Bob Chen <beef9999@qq.com> Co-authored-by: Huiba Li <huiba.lhb@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making thread_yield() possible to return error_number obtained from thread_interrupt()