Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission related pages should reset pageNum when searching #10917

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

maoling
Copy link
Contributor

@maoling maoling commented Aug 4, 2023

  • How to reproduce this bug:

    Suppose that I have 10 pages users data, when I jump to page 4, then I search username like "bob"
    then I search for nothing, in fact the data in the page 2, the parameter pageNo should
    be reset to 1, not 4.

  • The paging backend api seems not to work, I'll create another PR to fix it.

@codecov-commenter
Copy link

Codecov Report

Merging #10917 (eb7c709) into develop (de87bb3) will decrease coverage by 0.11%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10917      +/-   ##
=============================================
- Coverage      53.30%   53.19%   -0.11%     
- Complexity      5628     5629       +1     
=============================================
  Files            927      927              
  Lines          29568    29551      -17     
  Branches        3250     3249       -1     
=============================================
- Hits           15760    15719      -41     
- Misses         12437    12463      +26     
+ Partials        1371     1369       -2     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de87bb3...eb7c709. Read the comment docs.

@KomachiSion KomachiSion merged commit 3febc18 into alibaba:develop Aug 14, 2023
6 checks passed
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement. labels Aug 14, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants