Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10734] Optimize the param check implementation logic #10955

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[ISSUE #10734] Optimize the param check implementation logic #10955

merged 2 commits into from
Aug 14, 2023

Conversation

Sunrisea
Copy link
Contributor

@Sunrisea Sunrisea commented Aug 12, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Optimize the param checker implementation logic, improve scalability, and reserve interfaces for dynamically changing param check rules

Brief changelog

Optimize the param checker implementation logic, improve scalability, and reserve interfaces for dynamically changing param check rules

Verifying this change

For #10734

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [Y] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [Y] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [Y] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [Y] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [Y] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #10955 (091c4f6) into develop (86cf208) will increase coverage by 0.07%.
The diff coverage is 33.60%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10955      +/-   ##
=============================================
+ Coverage      53.16%   53.23%   +0.07%     
- Complexity      5627     5636       +9     
=============================================
  Files            927      928       +1     
  Lines          29555    29687     +132     
  Branches        3249     3276      +27     
=============================================
+ Hits           15713    15804      +91     
- Misses         12470    12502      +32     
- Partials        1372     1381       +9     
Files Changed Coverage Δ
.../nacos/console/filter/ConsoleParamCheckFilter.java 0.00% <0.00%> (ø)
...e/remote/grpc/GrpcServerParamCheckInterceptor.java 4.00% <0.00%> (-0.35%) ⬇️
...ibaba/nacos/naming/web/NamingParamCheckFilter.java 0.00% <0.00%> (ø)
...a/nacos/common/paramcheck/DefaultParamChecker.java 28.63% <30.97%> (+2.23%) ⬆️
...ba/nacos/common/paramcheck/ParamCheckResponse.java 57.14% <57.14%> (ø)
.../nacos/common/paramcheck/AbstractParamChecker.java 100.00% <100.00%> (ø)
...libaba/nacos/common/paramcheck/ParamCheckRule.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cf208...091c4f6. Read the comment docs.

@KomachiSion KomachiSion merged commit d756cdc into alibaba:develop Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants