Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CacheItem, it's better to use the private and final keywords to modify the member variable rwLock. #10964

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Bo-Qiu
Copy link
Contributor

@Bo-Qiu Bo-Qiu commented Aug 14, 2023

What is the purpose of the change

(Fix #10963 ) In CacheItem, it's better to use the private and final keywords to modify the member variable rwLock.

Brief changelog

(Fix #10963 ) In CacheItem, it's better to use the private and final keywords to modify the member variable rwLock.

… final keywords to modify the member variable rwLock.
@codecov-commenter
Copy link

Codecov Report

Merging #10964 (62474f6) into develop (37d45ad) will decrease coverage by 0.08%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10964      +/-   ##
=============================================
- Coverage      53.25%   53.18%   -0.08%     
- Complexity      5627     5630       +3     
=============================================
  Files            927      927              
  Lines          29556    29556              
  Branches        3250     3250              
=============================================
- Hits           15741    15720      -21     
- Misses         12441    12465      +24     
+ Partials        1374     1371       -3     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d45ad...62474f6. Read the comment docs.

@shiyiyue1102 shiyiyue1102 merged commit 84951e9 into alibaba:develop Aug 31, 2023
6 checks passed
@Bo-Qiu Bo-Qiu deleted the fix/10963 branch November 24, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each CacheItem instance should be permanently bound to a SimpleReadWriteLock instance.
3 participants