-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #11057]Add update instance and update service trace event for naming. #11069
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #11069 +/- ##
==============================================
+ Coverage 0 53.25% +53.25%
- Complexity 0 5662 +5662
==============================================
Files 0 935 +935
Lines 0 29806 +29806
Branches 0 3294 +3294
==============================================
+ Hits 0 15873 +15873
- Misses 0 12532 +12532
- Partials 0 1401 +1401
... and 929 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
||
private final boolean rpc; | ||
|
||
private final DeregisterInstanceReason reason; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
更新实例不需要这个字段吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,我修复一下。
|
||
private final String clientIp; | ||
|
||
private final boolean rpc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
更新实例应该只有http。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,我修复一下。
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Add update instance and update service trace event for naming.
For #11057 .
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.