Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11057]Add update instance and update service trace event for naming. #11069

Merged
merged 11 commits into from
Sep 6, 2023

Conversation

stone-98
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Add update instance and update service trace event for naming.
For #11057 .

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #11069 (3959cb1) into develop (ca34694) will increase coverage by 53.25%.
Report is 1 commits behind head on develop.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             develop   #11069       +/-   ##
==============================================
+ Coverage           0   53.25%   +53.25%     
- Complexity         0     5662     +5662     
==============================================
  Files              0      935      +935     
  Lines              0    29806    +29806     
  Branches           0     3294     +3294     
==============================================
+ Hits               0    15873    +15873     
- Misses             0    12532    +12532     
- Partials           0     1401     +1401     
Files Changed Coverage Δ
...n/trace/event/naming/UpdateInstanceTraceEvent.java 0.00% <0.00%> (ø)
...on/trace/event/naming/UpdateServiceTraceEvent.java 0.00% <0.00%> (ø)
...os/naming/controllers/v2/InstanceControllerV2.java 65.90% <85.71%> (ø)
...a/nacos/naming/controllers/InstanceController.java 83.43% <91.66%> (ø)
...ba/nacos/naming/controllers/ServiceController.java 79.56% <100.00%> (ø)
...cos/naming/controllers/v2/ServiceControllerV2.java 80.76% <100.00%> (ø)

... and 929 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca34694...3959cb1. Read the comment docs.


private final boolean rpc;

private final DeregisterInstanceReason reason;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新实例不需要这个字段吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,我修复一下。


private final String clientIp;

private final boolean rpc;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新实例应该只有http。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,我修复一下。

@KomachiSion KomachiSion merged commit 02fcbb0 into alibaba:develop Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants