Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11100] Update ConfigController.java, add srcUser when delete config by ids #11101

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

MajorHe1
Copy link
Collaborator

@MajorHe1 MajorHe1 commented Sep 7, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #11100

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #11101 (cdde8a7) into develop (279e488) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #11101   +/-   ##
==========================================
  Coverage      53.25%   53.25%           
+ Complexity      5666     5662    -4     
==========================================
  Files            935      935           
  Lines          29806    29806           
  Branches        3294     3294           
==========================================
  Hits           15873    15873           
+ Misses         12537    12532    -5     
- Partials        1396     1401    +5     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279e488...cdde8a7. Read the comment docs.

@KomachiSion KomachiSion merged commit 8c9934b into alibaba:develop Sep 14, 2023
6 checks passed
@MajorHe1 MajorHe1 deleted the MajorHe1-patch-1 branch September 18, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

src user missing when delete config by ids
4 participants