Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add outlier ejection #579

Merged
merged 16 commits into from
Oct 28, 2024
Merged

Conversation

wooyang2018
Copy link
Contributor

关联issue:#575

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2024

CLA assistant check
All committers have signed the CLA.

@wooyang2018 wooyang2018 changed the title [Feature] 添加离群摘除功能 | Add Outlier Ejection [feature] add outlier ejection Sep 21, 2024
Copy link
Collaborator

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this capability should be a function of the registry center, which can sense if the node is still alive/healthy. It can be discussed further

@EndlessSeeker
Copy link

  1. it is recommended that the outlier slot be optional. By default, the slot will not be executed unless specified to protect the original logic
  2. retryer and recycler need to be refactored to be more asynchronous to avoid blocking the core logic

Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit b8d94d1 into alibaba:master Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants