Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Kubernetes native configuration management #3119

Open
wants to merge 37 commits into
base: 2021.x
Choose a base branch
from
Open

Support Kubernetes native configuration management #3119

wants to merge 37 commits into from

Conversation

DanielLiu1123
Copy link
Collaborator

@DanielLiu1123 DanielLiu1123 commented Jan 29, 2023 •
edited
Loading

@DanielLiu1123 DanielLiu1123 force-pushed the k8s-config branch 2 times, most recently from 95c1310 to f03c903 Compare February 2, 2023 16:42
ruansheng8
ruansheng8 reviewed Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@ruansheng8 ruansheng8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module name may require further discussion, as previously determined, all sub-modules within the spring-cloud-alibaba-starters module has the same hierarchy level.

@ruansheng8
Copy link
Collaborator

Related #3137

@ruansheng8
Copy link
Collaborator

ruansheng8 commented Feb 4, 2023 •
edited
Loading

It may be necessary to create an Issue to explain the differences between the Spring Cloud Kubernetes and Spring Cloud Alibaba Kubernetes modules, as many community users may have questions in this regard during usage, as well as why a secondary development is not being carried out based on the foundation of Spring Cloud Kubernetes.

@steverao steverao closed this Feb 4, 2023
@steverao steverao reopened this Feb 4, 2023
@steverao
Copy link
Collaborator

steverao commented Feb 4, 2023 •
edited
Loading

It may be necessary to create an Issue to explain the differences between the Spring Cloud Kubernetes and Spring Cloud Alibaba Kubernetes modules, as many community users may have questions in this regard during usage, as well as why a secondary development is not being carried out based on the foundation of Spring Cloud Kubernetes.

Yes, I can't agree with it more, @DanielLiu1123 maybe you can add relevant explanation mentioned above in #3114 directly.

@steverao steverao requested review from HaojunRen and ruansheng8 March 5, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao Awaiting requested review from steverao

@yuhuangbin yuhuangbin Awaiting requested review from yuhuangbin

@HaojunRen HaojunRen Awaiting requested review from HaojunRen

@ruansheng8 ruansheng8 Awaiting requested review from ruansheng8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielLiu1123 @ruansheng8 @steverao