Rewrite deadbolt using modern electron IPC and typescript #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Let's go, in and out, quick 20 minute adventure No more javascript -- terrible language. This commit mostly works, but still needs some work on a few TODOs: - Errors not handled on failure to create encrypted file / decrypt file. Something related to electron/electron#24427 - Not always correctly identifying that the encrypted file HAS been created. This is a weird bug - CSS is a bit fucked still
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Awaiting `writeFileWithPromise` does not actually await writing the data to a file... Fucking stupid bug, who hired me to work on this
… verify the file contents after encryption Summary: Test Plan:
Summary: Test Plan:
…+ decryption Summary: Test Plan:
Summary: Test Plan:
alichtman
force-pushed
the
alichtman/electron-upgrade-refactor
branch
from
5dc66ad to
d8a2008
Compare
alichtman
force-pushed
the
alichtman/electron-upgrade-refactor
branch
from
7d48587 to
9f3f723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of the app. This PR mostly works.
Still needs some work on a few TODOs, primarily in the design of the
EncryptOrDecryptFormcomponent.FileHeadercomponent