[DA-4204] Adding Pagination to workbench/audit/workspace/snapshots API #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenny-skaggs
approved these changes
Apr 8, 2024
dtharpeuno
approved these changes
Apr 8, 2024
vmoniqb
changed the title
kenny-skaggs
reviewed
Apr 9, 2024
rdr_service/api/base_api.py
Outdated
| @@ -22,7 +22,7 @@ | |||
|
|
|||
|
|
|||
| DEFAULT_MAX_RESULTS = 100 | |||
| MAX_MAX_RESULTS = 10000 | |||
| MAX_MAX_RESULTS = 6000 | |||
There was a problem hiding this comment.
This update affects the Paricipant Summary API too. Is that intended, or should the code be updated to only set this as the max for the research workbench API's?
There was a problem hiding this comment.
This was intended, but after discussion in Slack, I will override the value instead to avoid any errors for awardees currently calling the PaarticipantSummary API with _count > 6000
kenny-skaggs
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DA-4204
Description of changes/additions
RH requested the ability to call the
workbench/audit/workspace/snapshotsAPI and return all workspaces. Previously, these calls have been failing due to the number of records in the response.This PR adds pagination to the API through both
workbench/audit/workspace/snapshotsandworkbench/audit/workspace/snapshots?last_snapshot_id=<ID>so that both can be used to fetch all workspaces.Tests