Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go defaults to "0"" so in case we want to return #181

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Go defaults to "0"" so in case we want to return #181

wants to merge 7 commits into from

Commits on Oct 9, 2019

  1. Go defaults to "0"" so in case we want to return 

    EntryStatus back to the caller "Expired" cannot be differentiated.
Fixing this by default "_" to 0 and incremental RemoveReasons

comment was missing for GetWithInfo api so updated that

test: ran all unit test cases
    @jgheewala
    jgheewala committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    91361a0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into expired_reason_iota_fix

    @jgheewala
    jgheewala authored Oct 9, 2019
    Configuration menu
    Copy the full SHA
    02f28af View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Merge branch 'master' into expired_reason_iota_fix

    @jgheewala
    jgheewala authored Aug 25, 2020
    Configuration menu
    Copy the full SHA
    1b84d1c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'master' into expired_reason_iota_fix

    @siennathesane
    siennathesane authored Aug 31, 2020
    Configuration menu
    Copy the full SHA
    8eb2dac View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Merge branch 'master' into expired_reason_iota_fix

    @jgheewala
    jgheewala authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e2ef8ae View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Merge branch 'master' into expired_reason_iota_fix

    @jgheewala
    jgheewala authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    83cd9cd View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Entry RemoveReason is iota based with default value being 0 

    Currently all const for RemovedReason are explicitly
set to avoid any breaking changes. For v3 migrating the reasons
to iota makes code readability and managing addition of more reasons
easier in the future.

Test: Validated all test cases run successfully.
    jgheewala committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c3845a8 View commit details
    Browse the repository at this point in the history