-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop printing message when doing a context shutdown #374
base: main
Are you sure you want to change the base?
Conversation
Good catch, thanks! |
Probably this was the reason :) https://github.com/allegro/bigcache/actions/runs/6145556141/job/16673759956?pr=374#step:5:25 |
I honestly have no idea why it would cause that. |
AFAIR it's because during a test run If you're curious to fix it than try to replace this context with Line 63 in 157556c
And if you're not curious (which is fine too) I will take a look later today (leaving PR open for some time). Thanks. |
go func() { | ||
logger := newLogger(config.Logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will solve the data race
go func() { | |
logger := newLogger(config.Logger) | |
logger := newLogger(config.Logger) | |
go func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! anyway, replacing ctx is also a good thing for the future.
@rubenv Ping |
Uses the configured logger instead.