feat: use mmap to alloc big chunk of memory #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
reviewed
Jun 28, 2024
| @@ -1,4 +1,4 @@ | |||
| # BigCache [](https://github.com/allegro/bigcache/actions?query=workflow%3Abuild) [](https://coveralls.io/github/allegro/bigcache?branch=main) [](https://godoc.org/github.com/allegro/bigcache/v3) [](https://goreportcard.com/report/github.com/allegro/bigcache/v3) | |||
| # BigCache [](https://github.com/allegro/bigcache/actions?query=workflow%3Abuild) [](https://coveralls.io/github/allegro/bigcache?branch=main) [](https://godoc.org/github.com/tecty/bigcache/v3) [](https://goreportcard.com/report/github.com/tecty/bigcache/v3) | |||
There was a problem hiding this comment.
I will use another branch to minimize the changes.
| @@ -4,6 +4,8 @@ import ( | |||
| "encoding/binary" | |||
| "log" | |||
| "time" | |||
|
|
|||
| "golang.org/x/sys/unix" | |||
There was a problem hiding this comment.
I like that bigcache has no external deps
Also with unix we should add a build tags to not use it on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mmap to malloc memory, give a smaller heap memory footprint. This will remove the go memory ballast effect while using bigcache. Thus this will increase a bit on GC stop and CPU. But we have other tools like GC params or gctuner to mitigate this kind of problem.
