Revert change to how expiration timings to calculated. #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing upgrading from v3.0.2 to v3.1.0, I've noticed a small bug impactful (to me) change around how expirations are calculated.
If you set a
LifeWindow
of1s
, add an entry, and wait 1100ms, the entry does not expire. Testing it a bit more, I've discovered that it actually expires if you wait2s
.You can see this regression in code when comparing the old logic here with the new logic here.
For convenience, old logic:
new logic:
This change reverts that logic to the old behavior.