Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Condition for stylecop.json inclusion #21

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix: correct Condition for stylecop.json inclusion #21

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcd3696
fix: correct Condition for stylecop.json inclusion
amis92 Apr 9, 2024
9e00226
fix: working directory to run tests and use sln
ppiwow-apay Apr 10, 2024
f8b4c84
chore: bump to v2.2.2
amis92 Apr 10, 2024
e09e1ad
test: allow rollForward for Net8SdkValid test
amis92 Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Allegro.DotnetSdk/Sdk/Allegro.NET.Sdk.CSharp.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
</PropertyGroup>

<!--
Include stylecop configuration if we include StyleCop analyzer within this Sdk,
or if it was included externally as GlobalPackageReference when CPM is enabled.
Include stylecop configuration if StyleCop was included externally as GlobalPackageReference when CPM is enabled.
-->
<ItemGroup Condition="'$(AllegroDotnetSdkEnableStyleCopConfig)' == 'true' Or @(GlobalPackageReference->WithMetadataValue('Identity','StyleCop.Analyzers')->Count()) > 0)">
<ItemGroup Condition="'$(AllegroDotnetSdkEnableStyleCopConfig)' == 'true' And @(GlobalPackageReference->WithMetadataValue('Identity','StyleCop.Analyzers')->Count()) > 0">
<AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" />
</ItemGroup>

Expand All @@ -23,4 +22,4 @@
<Using Remove="System.Net.Http" />
</ItemGroup>

</Project>
</Project>
Loading