Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests #25

Merged
merged 16 commits into from
Aug 6, 2023
Merged

Adding tests #25

merged 16 commits into from
Aug 6, 2023

Conversation

soldni
Copy link
Member

@soldni soldni commented Aug 5, 2023

No description provided.

@soldni soldni marked this pull request as draft August 5, 2023 16:35
@soldni soldni marked this pull request as ready for review August 5, 2023 18:29
@soldni soldni marked this pull request as draft August 5, 2023 18:30
@soldni soldni requested a review from kyleclo August 6, 2023 20:37
@soldni soldni marked this pull request as ready for review August 6, 2023 20:37
kyleclo
kyleclo reviewed Aug 6, 2023
View reviewed changes
papermage/magelib/entity.py Outdated Show resolved Hide resolved
kyleclo
kyleclo approved these changes Aug 6, 2023
View reviewed changes
Copy link
Collaborator

@kyleclo kyleclo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; pls check out the 2 comments

@soldni soldni merged commit ce4191f into main Aug 6, 2023
3 checks passed
@soldni soldni deleted the soldni/tests branch August 6, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleclo kyleclo kyleclo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soldni @kyleclo