Kylel/2023/wrappers #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soldni
approved these changes
Aug 6, 2023
papermage/magelib/document.py
Outdated
| def check_field_name_availability(self, field_name: str) -> None: | ||
| if field_name in self.SPECIAL_FIELDS: | ||
| raise AssertionError(f"{field_name} not allowed Document.SPECIAL_FIELDS.") | ||
| if field_name in self.__entity_span_indexers.keys(): | ||
| raise AssertionError(f"{field_name} already exists. Try `is_overwrite=True`") | ||
| raise AssertionError(f"{field_name} already exists. Try `doc.remove_entity({field_name})` first.") |
There was a problem hiding this comment.
Suggested change
| raise AssertionError(f"{field_name} already exists. Try `doc.remove_entity({field_name})` first.") | |
| raise AssertionError(f"{field_name} already exists. Try `doc.remove_entity(\"{field_name}\")` first.") |
Nit, but otherwise it looks like you are providing a variable.
papermage/magelib/document.py
Outdated
Comment on lines
76
to
80
| def annotate(self, field_name: str, entiites: List[Entity]) -> None: | ||
| if isinstance(entiites[0], Entity): | ||
| self.annotate_entity(field_name=field_name, entities=entiites) | ||
| else: | ||
| raise NotImplementedError(f"Unsupported entity type {type(entiites[0])}") |
There was a problem hiding this comment.
Suggested change
| def annotate(self, field_name: str, entiites: List[Entity]) -> None: | |
| if isinstance(entiites[0], Entity): | |
| self.annotate_entity(field_name=field_name, entities=entiites) | |
| else: | |
| raise NotImplementedError(f"Unsupported entity type {type(entiites[0])}") | |
| def annotate(self, field_name: str, entiites: List[Entity]) -> None: | |
| if all(isinstance(e, Entity) for e in entities): | |
| self.annotate_entity(field_name=field_name, entities=entiites) | |
| else: | |
| raise NotImplementedError(f"entity list contains non-entities: {[type(e) for e in entities]}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.