Add code for training and running inference with huggingface predictors #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewm0609
commented
Jul 21, 2023
| self, | ||
| document: Document, | ||
| context_name: str | ||
| ) -> List[EntityClassificationBatch]: |
There was a problem hiding this comment.
Just want to note that preprocess and postprocess don't pass type checking because their signatures are different from the superclass.
bnewm0609
commented
Jul 21, 2023
| raise ValueError("This annotation is not attached to a document") | ||
|
|
||
| if field in self.doc.fields: | ||
| return self.doc.find_span_overlap_entities(self, field) |
There was a problem hiding this comment.
I'm not sure why this line type-checks. self is an Annotation, but the first argument of self.doc.find_span_overlap_entities should be an Entity. Do we want to be able to intersect overlapping Annotation or just overlapping Entitys?
bnewm0609
commented
Jul 21, 2023
| @property | ||
| def fields(self) -> List[str]: | ||
| return list(self.__entity_span_indexers.keys()) | ||
|
|
There was a problem hiding this comment.
mmda uses a separate list of fields, but is there any reason we can just use the indexer keys for simplicity?
added 7 commits
July 24, 2023 18:19
kyleclo
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is needed for this PR: