Remove Restriction on Pandas Version #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleclo
approved these changes
Feb 15, 2024
|
Sure thing! I just made a change to bump the version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I noticed that
papermagecurrently restricts the version ofpandasto bepandas<2, however I don't believe the project explicitly imports and uses the package. This is a bit of a challenge for developers using this project because a lot of other projects are upgrading topandas>=2to make use of new functionalities, which causes issues in dependency resolution.I created a fork in which I removed the restriction, ran the CI pipeline, and found that the builds for Python 3.8, 3.9, and 3.11 all passed. As such -- unless there is a good reason for keeping the version at
pandas<2(which there very might well be) -- I was wondering if you would be willing to remove the restriction to make it easier for downstream developers to incorporate your awesome work into our project(s)!