Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): Replace magic numbers for tx type with constants #1911

Merged
merged 1 commit into from
Jan 12, 2025
+12 −6
Merged

chore(consensus): Replace magic numbers for tx type with constants #1911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions crates/consensus/src/transaction/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
//! Transaction types.

use crate::Signed;
use crate::{
constants::{
EIP1559_TX_TYPE_ID, EIP2930_TX_TYPE_ID, EIP4844_TX_TYPE_ID, EIP7702_TX_TYPE_ID,
LEGACY_TX_TYPE_ID,
},
Signed,
};
use alloc::vec::Vec;
use alloy_eips::{eip2930::AccessList, eip7702::SignedAuthorization};
use alloy_primitives::{keccak256, Address, Bytes, ChainId, TxKind, B256, U256};
Expand Down Expand Up @@ -356,26 +362,26 @@ pub trait Typed2718 {

/// Returns true if the type is a legacy transaction.
fn is_legacy(&self) -> bool {
self.ty() == 0
self.ty() == LEGACY_TX_TYPE_ID
}

/// Returns true if the type is an EIP-2930 transaction.
fn is_eip2930(&self) -> bool {
self.ty() == 1
self.ty() == EIP2930_TX_TYPE_ID
}

/// Returns true if the type is an EIP-1559 transaction.
fn is_eip1559(&self) -> bool {
self.ty() == 2
self.ty() == EIP1559_TX_TYPE_ID
}

/// Returns true if the type is an EIP-4844 transaction.
fn is_eip4844(&self) -> bool {
self.ty() == 3
self.ty() == EIP4844_TX_TYPE_ID
}

/// Returns true if the type is an EIP-7702 transaction.
fn is_eip7702(&self) -> bool {
self.ty() == 4
self.ty() == EIP7702_TX_TYPE_ID
}
}
Loading