Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interop): Define ExecutingMessage wrapper #361

Merged
merged 4 commits into from
Jan 7, 2025
Merged

feat(interop): Define ExecutingMessage wrapper #361

merged 4 commits into from
Jan 7, 2025

Conversation

emhane
Copy link
Collaborator

@emhane emhane commented Jan 6, 2025 •
edited
Loading

Motivation

Closes #360

Solution

Defines ExecutingMessage wrapper for ExecutingMessageAbi.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane requested a review from DaniPopes January 6, 2025 21:55
@emhane emhane marked this pull request as draft January 6, 2025 22:05
@emhane
Copy link
Collaborator Author

emhane commented Jan 6, 2025

hm, this feels redundant, changing it up a bit.

@emhane emhane marked this pull request as ready for review January 6, 2025 23:33
@emhane
Copy link
Collaborator Author

emhane commented Jan 6, 2025

couldn't remove the redundancy due to conversion of sol struct fields from u256 to u64

@emhane emhane changed the title feat(interop): Define InteropMessage feat(interop): Define ExecutingMessage wrapper Jan 6, 2025
refcell
refcell approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good by me - can always try and clean up again later.

@refcell refcell added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 52b28b7 Jan 7, 2025
20 checks passed
@refcell refcell deleted the emhane/interop-msg branch January 7, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Impl Serialize for ExecutingMessage
2 participants
@emhane @refcell