feat(rpc-types): OP Error Types #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
A-rpc-types
emhane
reviewed
Aug 30, 2024
Comment on lines
+13
to
+21
| /// Thrown when calculating L1 gas fee. | ||
| #[error("failed to calculate l1 gas fee")] | ||
| L1BlockFeeError, | ||
| /// Thrown when calculating L1 gas used | ||
| #[error("failed to calculate l1 gas used")] | ||
| L1BlockGasError, | ||
| /// Wrapper for [`revm_primitives::InvalidTransaction`]. | ||
| #[error(transparent)] | ||
| InvalidTransaction(OptimismInvalidTransactionError), |
There was a problem hiding this comment.
would it be ok to just incorporate these variants in a new error type and leave the rest in reth?
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
|
Closing this for now since it can live in reth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstream error types from
reth/optimismtorpc-types.Not a huge fan of the generic
EthApiErroron theOpEthApiErrortype.Also unfortunate we need to copy over
internal_rpc_errandrpc_errfunctions since they're custom reth utils.Close #40.