Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing undefined includes #885

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fixing undefined includes #885

merged 1 commit into from
Sep 9, 2024

Conversation

IanWoodard
Copy link
Collaborator

Fixing a bug where we try to check if the bad debt lenders includes a certain asset, even if there is no bad debt on that chain. To fix this, I added optional chaining to prevent this from crashing in the case where the selected chain doesn't have any pairs with bad debt and row.suppliedBalance > row.withdrawableBalance (which is when the bug occurs).

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for aloe-prime canceled.

Name Link
🔨 Latest commit 15d5e55
🔍 Latest deploy log https://app.netlify.com/sites/aloe-prime/deploys/66d4b6267a0c260008f27fe1

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for aloe-earn ready!

Name Link
🔨 Latest commit 15d5e55
🔍 Latest deploy log https://app.netlify.com/sites/aloe-earn/deploys/66d4b6261764df00086b8b14
😎 Deploy Preview https://deploy-preview-885--aloe-earn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for aloe-blend-staging canceled.

Name Link
🔨 Latest commit 15d5e55
🔍 Latest deploy log https://app.netlify.com/sites/aloe-blend-staging/deploys/66d4b6261a2afb0009ca9472

@IanWoodard IanWoodard merged commit e7655bb into master Sep 9, 2024
18 checks passed
@IanWoodard IanWoodard deleted the iw/fix-includes branch September 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants