Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from .transfer to solmate's safeTransferETH #210

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

haydenshively
Copy link
Member

Copy link

Changes to gas cost

Generated at commit: a9f86609411d8cb7befabdadd3f181da1a6ce92a, compared to commit: 8a608f07f9214c7094d63d7a37b13b1c9bdaf89d

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
BorrowerDeployer deploy +31,880 ❌ +0.97%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
BorrowerDeployer 3,547,389 (+31,841) deploy 3,317,437 (+31,880) +0.97% 3,317,853 (+31,880) +0.97% 3,317,437 (+31,880) +0.97% 3,319,937 (+31,880) +0.97% 18 (0)
Borrower 3,283,607 (+31,840) liquidate 0 (0) +∞% 53,573 (-23) -0.04% 50,074 (-35) -0.07% 127,953 (-6) -0.00% 6 (0)

@haydenshively haydenshively requested a review from aneesh1 November 7, 2023 01:15
@haydenshively haydenshively changed the base branch from master to sherlock-audit-fixes November 8, 2023 20:52
@haydenshively haydenshively merged commit 8235845 into sherlock-audit-fixes Nov 18, 2023
3 of 4 checks passed
@haydenshively haydenshively deleted the fix-8-eth-transfers branch November 18, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant