Merge pull request #1667 from alphagov/sengi/cwe-20

Fix incomplete regex escape function.
alphagov · Mar 26, 2024 · 3aad042 · 3aad042
2 parents 97b34ea + 846c8ed
commit 3aad042
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/app/assets/javascripts/filter-table.js b/app/assets/javascripts/filter-table.js
@@ -50,11 +50,9 @@
         GOVUKAdmin.redirect(link.attr('href'))
       }
 
-      // http://stackoverflow.com/questions/3446170/escape-string-for-use-in-javascript-regex
-      // https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/regexp
-      // Escape ~!@#$%^&*(){}[]`/=?+\|-_;:'",<.>
       function escapeStringForRegexp (str) {
-        return str.replace(/[-[\]/{}()*+?.^$|]/g, '\\$&')
+        // https://github.com/tc39/proposal-regex-escaping
+        return str.replace(/[\\^$*+?.()|[\]{}]/g, '\\$&')
       }
     }
   }