SS/ACB - fix erb-lint violations in views/application

alphagov · Sep 13, 2023 · 9cf48b8 · 9cf48b8
1 parent 673ab7f
commit 9cf48b8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/app/views/application/_aggregated_tag_mappings.html.erb b/app/views/application/_aggregated_tag_mappings.html.erb
@@ -6,11 +6,11 @@
     <td>
       <% aggregated_tagging.links.each do |tag_link| %>
         <%= link_to tag_link.link_title, taxon_path(tag_link.link_content_id) %> (<%= tag_link.link_type %>)
-        <br />
-      <% end%>
+        <br>
+      <% end %>
 
       <% if aggregated_tagging.errored? %>
-        <hr />
+        <hr>
         <span class="error-message">
           <ul>
             <% aggregated_tagging.error_messages.each do |error_message| %>

diff --git a/app/views/application/_tag_update_preview.html.erb b/app/views/application/_tag_update_preview.html.erb
@@ -1,13 +1,13 @@
 <div class="tag-update-preview">
-  <br/>
+  <br>
 
   <div data-module="tag-update-progress">
     <% if aggregated_tag_mappings.any? %>
       <%= render partial: "tag_update_progress_bar",
         locals: {
           completed_tag_mappings: completed_tag_mappings,
           total_tag_mappings: total_tag_mappings,
-          progress_path: progress_path
+          progress_path: progress_path,
         } %>
     <% end %>
   </div>
@@ -21,11 +21,11 @@
         <th></th>
       </tr>
 
-      <%= render partial: 'shared/table_filter' %>
+      <%= render partial: "shared/table_filter" %>
     </thead>
 
     <tbody>
-      <%= render partial: 'aggregated_tag_mappings',
+      <%= render partial: "aggregated_tag_mappings",
         locals: { aggregated_tag_mappings: aggregated_tag_mappings } %>
     </tbody>
   </table>

diff --git a/app/views/application/_tag_update_progress_bar.html.erb b/app/views/application/_tag_update_progress_bar.html.erb
@@ -2,7 +2,7 @@
 <div class="js-tag-update-progress" data-progress-path="<%= progress_path %>">
 
   <div class="progress">
-    <div class="progress-bar <%= 'progress-bar-striped active' unless percentage_complete == 100 %>"
+    <div class="progress-bar <%= "progress-bar-striped active" unless percentage_complete == 100 %>"
       role="progressbar"
       aria-valuenow="<%= completed_tag_mappings %>"
       aria-valuemin="0"
@@ -14,7 +14,7 @@
 
   <div class="progress-counter">
     <p>
-      <%= I18n.t('views.tag_update_progress_bar', completed: completed_tag_mappings, total: total_tag_mappings)%>
+      <%= I18n.t("views.tag_update_progress_bar", completed: completed_tag_mappings, total: total_tag_mappings) %>
     </p>
   </div>