Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move actionlint problem-matcher inline so it works cross-repo. #1375

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Jul 8, 2024

Drop the ANSI colour codes to simplify the regex. These were already ignored anyway.

The pre-merge check fails on this PR because it's calling the old version of the reusable action that expects to find the separate file for the problem matcher, which we're removing. It'll work once merged. (Didn't seem worth making two PRs just to make the checks happy, since I needed to test it separately anyway.)

Tested: https://github.com/alphagov/govuk-ruby-images/actions/runs/9842609154/job/27172037545#step:3:53

#1361

Drop the ANSI colour codes to simplify the regex. These were already
ignored anyway.
@sengi sengi requested a review from theseanything July 8, 2024 15:40
@sengi sengi merged commit 8830356 into main Jul 8, 2024
1 check failed
@sengi sengi deleted the sengi/actionlint branch July 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants