Consolidate linters with github/super-linter.
#103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseanything
previously approved these changes
Jul 8, 2024
sengi
force-pushed
the
sengi/actionlint
branch
5 times, most recently
from
f228b06 to
8a80276
Compare
This gets rid of a lot of ugly glue that we'd otherwise have to continue maintaining ourselves. Enable the linters we we running before, plus actionlint.
|
Rather than faff about getting problem-matchers to work, decided to look around and found we can replace all our home-grown linter actions glue with PTAL |
sengi
changed the title
github/super-linter + enable actionlint.
sengi
commented
Jul 8, 2024
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
I verified that it really does require this, even though we're not currently using any of the linters which use the commit history 🤷
sengi
added a commit
to alphagov/govuk-infrastructure
that referenced
this pull request
Jul 8, 2024
sengi
added a commit
to alphagov/govuk-infrastructure
that referenced
this pull request
Jul 8, 2024
sengi
changed the title
github/super-linter + enable actionlint.github/super-linter.
sengi
dismissed
theseanything’s stale review
changed scope and probably won't merge this soon, thanks for the review tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in much less config and way better capability. It's slightly slower because of the image pull (not sure why it's not cached better) but it still takes under a minute so I think it's worth it since it's way easier to enable other linters in future and eliminates a lot of maintenance.
Alternatives considered:
Neither super-linter nor Reviewdog seems to integrate with GitHub problem matchers yet, so holding off on this for now since we currently have problems matchers working (i.e. findings shown inline with code in the GitHub review UI) and they're pretty valuable.